Open
Conversation
c369190 to
a456367
Compare
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
erickzhao
requested changes
Mar 13, 2026
Member
erickzhao
left a comment
There was a problem hiding this comment.
Plugin code seems pretty straightforward but we need to update some config stuff on the library side (^:
Co-authored-by: Erick Zhao <erick@hotmail.ca>
…plugin Co-authored-by: Erick Zhao <erick@hotmail.ca>
Co-authored-by: Erick Zhao <erick@hotmail.ca>
Author
|
Thanks for the comments @erickzhao ! What are your thoughts on these three line items from my original post?
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summarize your changes:
This follows up electron/asar#380, which implements a management API for electron/electron#48587.
Some additional things we might want to do: